feat: update object similarity calculation - #9
Merged
Conversation
- now structure similarity is 60% of the result and value similarity is 40% of the result - the value similarity is now `number of value match / number of expected property` instead of `number of value match / number of matched keys`. This avoids to have a high ratio if only one key match the expected object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
number of value match / number of expected propertyinstead ofnumber of value match / number of matched keys. This avoids to have a high ratio if only one key match the expected object.before:
{ "a": 1, "d": 5 }and{ "a": 1, "d": 2 }: have a value similarity equals to 0.5{ "a": 1, "d": 5 }and{ "a": 1 }: have a value similarity equals to 1now:
{ "a": 1, "d": 5 }and{ "a": 1, "d": 2 }: have a value similarity equals to 0.5{ "a": 1, "d": 5 }and{ "a": 1 }: have a value similarity equals to 0.5close #8